Fixup serdeany_autoreg #2721
Merged
Fixup serdeany_autoreg #2721
+45
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@domenukk now the error is very different, seemingly unrelated (ld: file format not recognised 😵💫). Otherwise this is done. |
addisoncrump
commented
Nov 23, 2024
There was a problem hiding this comment.
FYI: This file got roped into this change by accident but they are still minor bugfixes.
|
Amazing, thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some concerns we discussed about serdeany to ensure that it doesn't rely on features which aren't present downstream.