LibAFL_QEMU: Don't return a generic Address from Register reads #2681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenukk
commented
Nov 12, 2024
| @@ -138,7 +138,7 @@ where | |||
| qemu: Qemu, | |||
| arch_regs_map: &'static EnumMap<ExitArgs, Regs>, | |||
| ) -> Result<Self::OutputCommand, CommandError> { | |||
| let input_virt_addr: GuestVirtAddr = qemu.read_reg(arch_regs_map[ExitArgs::Arg1])?; | |||
| let input_virt_addr: GuestVirtAddr = qemu.read_reg(arch_regs_map[ExitArgs::Arg1])?.into(); | |||
There was a problem hiding this comment.
@rmalmain Don't really understand why GuestVirtAddr can be a different size to GuestReg, but anyway not a big issue
There was a problem hiding this comment.
this is more for semantic purposes, most of the time len(GuestReg) = len(GuestVirtAddr) >= len(GuestPhysAddr).
so we could just use GuestReg everywhere in theory i think.
it's just convenient to know what exactly we manipulate with the type.
|
This is done, CI is flakey because of Libafl-fuzz |
|
looks good, thanks |
|
i guess we could do something similar for register writes as well |
|
Writes are not necessary, usually the compiler can figure out the types. But up to you. |
riesentoaster
pushed a commit
to riesentoaster/LibAFL
that referenced
this pull request
Nov 21, 2024
…lusplus#2681) * LibAFL_QEMU: Make ReadReg always return GuestReg type * Don't return a generic address * fix fuzzers * fix mips
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.