Trying to redo workspace deps #2672
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tokatoka I'm stuck on ahash-> foldhash, you did that already right? |
|
no i didn't |
|
Ah dang. I think switching the whole codebase is the right thing to do, but I'm a bit stuck |
|
see discord. i don't think we should change to foldhash now |
|
Restarting without chaging the hashbrown version |
domenukk
added a commit
that referenced
this pull request
Nov 9, 2024
|
We won't update hashbrown and switch our hashing function (as I tried in #2672) to 0.15 until this issue looks better rust-lang/hashbrown#577 |
|
Continuing this in #2673 instead |
domenukk
added a commit
that referenced
this pull request
Nov 9, 2024
* Trying to redo workspace deps again after #2672 * unused * clippy
riesentoaster
pushed a commit
to riesentoaster/LibAFL
that referenced
this pull request
Nov 9, 2024
* Trying to redo workspace deps again after AFLplusplus#2672 * unused * clippy
riesentoaster
pushed a commit
to riesentoaster/LibAFL
that referenced
this pull request
Nov 9, 2024
* Trying to redo workspace deps again after AFLplusplus#2672 * unused * clippy
riesentoaster
pushed a commit
to riesentoaster/LibAFL
that referenced
this pull request
Nov 9, 2024
* Trying to redo workspace deps again after AFLplusplus#2672 * unused * clippy
riesentoaster
pushed a commit
to riesentoaster/LibAFL
that referenced
this pull request
Nov 9, 2024
* Trying to redo workspace deps again after AFLplusplus#2672 * unused * clippy
riesentoaster
pushed a commit
to riesentoaster/LibAFL
that referenced
this pull request
Nov 9, 2024
* Trying to redo workspace deps again after AFLplusplus#2672 * unused * clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to un-undo #2652