Replace addr_of with &raw across the codebase #2669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmalmain
reviewed
Nov 7, 2024
| @@ -27,8 +24,8 @@ use libafl_bolts::{rands::StdRand, tuples::tuple_list, AsSlice}; | |||
|
|
|||
| /// Coverage map with explicit assignments due to the lack of instrumentation | |||
| static mut SIGNALS: [u8; 64] = [0; 64]; | |||
| static mut SIGNALS_PTR: *mut u8 = addr_of_mut!(SIGNALS).cast(); | |||
| static mut SIGNALS_LEN: usize = unsafe { (*addr_of!(SIGNALS)).len() }; | |||
| static mut SIGNALS_PTR: *mut u8 = &raw mut (SIGNALS).cast(); | |||
There was a problem hiding this comment.
we don't need all these parentheses anymore, i guess.
or maybe some like this: (&raw const ...) instead of &raw const (...) to enforce operation prioritization.
There was a problem hiding this comment.
Trying to get rid of some manually, but it's work :D sholud be done with a regex
There was a problem hiding this comment.
This one in particular should use ConstLenObserver anyway, right?
riesentoaster
pushed a commit
to riesentoaster/LibAFL
that referenced
this pull request
Nov 9, 2024
* Replace addr_of with &raw across the codebase * fix fixes * more fix * undo clang fmt? * oops * fix? * allocator fix * more fix * more more * more docs * more fix * mas mas mas * hm * more * fix Frida * needed * more error * qemu
riesentoaster
pushed a commit
to riesentoaster/LibAFL
that referenced
this pull request
Nov 9, 2024
* Replace addr_of with &raw across the codebase * fix fixes * more fix * undo clang fmt? * oops * fix? * allocator fix * more fix * more more * more docs * more fix * mas mas mas * hm * more * fix Frida * needed * more error * qemu
riesentoaster
pushed a commit
to riesentoaster/LibAFL
that referenced
this pull request
Nov 9, 2024
* Replace addr_of with &raw across the codebase * fix fixes * more fix * undo clang fmt? * oops * fix? * allocator fix * more fix * more more * more docs * more fix * mas mas mas * hm * more * fix Frida * needed * more error * qemu
riesentoaster
pushed a commit
to riesentoaster/LibAFL
that referenced
this pull request
Nov 9, 2024
* Replace addr_of with &raw across the codebase * fix fixes * more fix * undo clang fmt? * oops * fix? * allocator fix * more fix * more more * more docs * more fix * mas mas mas * hm * more * fix Frida * needed * more error * qemu
riesentoaster
pushed a commit
to riesentoaster/LibAFL
that referenced
this pull request
Nov 9, 2024
* Replace addr_of with &raw across the codebase * fix fixes * more fix * undo clang fmt? * oops * fix? * allocator fix * more fix * more more * more docs * more fix * mas mas mas * hm * more * fix Frida * needed * more error * qemu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More modern rust is more modern