Modifications to work with MS Windows #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxml only works with posix type paths so change path to this type to start with by the function posix_path(). also normpath removed in EpubWriter.py. This works with the test file but needs more comprehensive testing. Since Python works on windows with posix paths it might be possible to remove all os functions
|
I don't think these mods could do any harm on linux. There could be a better way of doing it and it would need testing for all possible inputs and outputs. It works with these files: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lxml only works with posix type paths so change path to this type
to start with by the function posix_path().
also normpath removed in EpubWriter.py.
This works with the test file but needs more comprehensive
testing.
Since Python works on windows with posix paths it might be
possible to remove all os functions