-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tests): sql_cmd_test and no impl for MakeMergeNode
#3829
fix(tests): sql_cmd_test and no impl for MakeMergeNode
#3829
Conversation
aceforeverd
commented
Mar 23, 2024
•
edited
Loading
edited
- fix CI building
- necessary fix to sql_cmd_test, at least delegate error rate in sql_cmd_test too easy to fail #3751
- necessary fix to many undeleted files in /tmp #1958
fix CI building
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3829 +/- ##
=============================================
+ Coverage 40.69% 74.84% +34.14%
Complexity 658 658
=============================================
Files 195 742 +547
Lines 11650 133754 +122104
Branches 1384 1379 -5
=============================================
+ Hits 4741 100108 +95367
- Misses 6605 33342 +26737
Partials 304 304 ☔ View full report in Codecov by Sentry. |
SDK Test Report101 files ±0 101 suites ±0 2m 12s ⏱️ +2s Results for commit 1ad02d8. ± Comparison against base commit 4c6406e. This pull request removes 30 and adds 9 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Linux Test Report 57 files + 4 244 suites +184 1h 40m 17s ⏱️ + 1h 12m 17s Results for commit 1ad02d8. ± Comparison against base commit 4c6406e. ♻️ This comment has been updated with latest results. |
HybridSE Mac Test Report20 116 tests 20 114 ✅ 8m 11s ⏱️ Results for commit 1ad02d8. ♻️ This comment has been updated with latest results. |
HybridSE Linux Test Report20 116 tests 20 114 ✅ 6m 34s ⏱️ Results for commit 1ad02d8. ♻️ This comment has been updated with latest results. |
90ddf25
to
d7aeb71
Compare
MakeMergeNode
MakeMergeNode
d7aeb71
to
4e44f62
Compare
1. recycle_bin_root_path does not setted up randomly and get cleaned up after test down. 2. UTs should ensure cleanup even test fails, missed cleanup might affect subsequent tests 3. cleanup tmp dirs even on signal 4. workaround: standalone & cluster env require distinct db_root_path 5. fix sql_cluster_test
4e44f62
to
1ad02d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM