Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): sql_cmd_test and no impl for MakeMergeNode #3829

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

aceforeverd
Copy link
Collaborator

@aceforeverd aceforeverd commented Mar 23, 2024

@github-actions github-actions bot added the execute-engine hybridse sql engine label Mar 23, 2024
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 95.69892% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 74.84%. Comparing base (0a5fa74) to head (1ad02d8).
Report is 3 commits behind head on main.

Files Patch % Lines
src/test/util.cc 91.89% 3 Missing ⚠️
src/apiserver/api_server_test.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3829       +/-   ##
=============================================
+ Coverage     40.69%   74.84%   +34.14%     
  Complexity      658      658               
=============================================
  Files           195      742      +547     
  Lines         11650   133754   +122104     
  Branches       1384     1379        -5     
=============================================
+ Hits           4741   100108    +95367     
- Misses         6605    33342    +26737     
  Partials        304      304               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Mar 23, 2024

SDK Test Report

101 files  ±0  101 suites  ±0   2m 12s ⏱️ +2s
349 tests ±0  335 ✅ ±0  14 💤 ±0  0 ❌ ±0 
475 runs  ±0  461 ✅ ±0  14 💤 ±0  0 ❌ ±0 

Results for commit 1ad02d8. ± Comparison against base commit 4c6406e.

This pull request removes 30 and adds 9 tests. Note that renamed tests count towards both.
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
 ) limit 10;](2)
 ) limit 10;](3)
 FROM db1.t1
 FROM t1
 WINDOW w1 AS (
 last join db2.t2 order by db2.t2.col1
…
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[,  SELECT sum(db1.t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM db1.t1
 last join db2.t2 order by db2.t2.col1
 on db1.t1.col1 = db2.t2.col1 and db1.t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](2)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[db1,  SELECT sum(t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[null,  SELECT sum(db1.t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM db1.t1
 last join db2.t2 order by db2.t2.col1
 on db1.t1.col1 = db2.t2.col1 and db1.t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](3)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Fail to transform data provider op: table t1 not exists in database []](4)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT db1.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: db1.t2.str1](2)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: .t2.col1](3)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: .t2.str1](1)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[null, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Fail to transform data provider op: table t1 not exists in database []](5)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlWindowLastJoin[ SELECT sum(t1.col1) over w1 as sum_t1_col1, t2.str1 as t2_str1
 FROM t1
 last join t2 order by t2.col1
 on t1.col1 = t2.col1 and t1.col2 = t2.col0
 WINDOW w1 AS (
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 23, 2024

Linux Test Report

    57 files  +     4     244 suites  +184   1h 40m 17s ⏱️ + 1h 12m 17s
12 620 tests +11 949  12 613 ✅ +11 962  7 💤 ±0  0 ❌  - 13 
17 892 runs  +17 220  17 885 ✅ +17 233  7 💤 ±0  0 ❌  - 13 

Results for commit 1ad02d8. ± Comparison against base commit 4c6406e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 23, 2024

HybridSE Mac Test Report

20 116 tests   20 114 ✅  8m 11s ⏱️
   256 suites       2 💤
    68 files         0 ❌

Results for commit 1ad02d8.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 23, 2024

HybridSE Linux Test Report

20 116 tests   20 114 ✅  6m 34s ⏱️
   256 suites       2 💤
    68 files         0 ❌

Results for commit 1ad02d8.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Mar 26, 2024
@aceforeverd aceforeverd changed the title fix: no impl for MakeMergeNode fix(tests): sql_cmd_test and no impl for MakeMergeNode Mar 26, 2024
@github-actions github-actions bot added api-server and removed storage-engine openmldb storage engine. nameserver & tablet labels Mar 27, 2024
1. recycle_bin_root_path does not setted up randomly and get cleaned up
after test down.
2. UTs should ensure cleanup even test fails, missed cleanup might
   affect subsequent tests
3. cleanup tmp dirs even on signal
4. workaround: standalone & cluster env require distinct db_root_path
5. fix sql_cluster_test
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vagetablechicken vagetablechicken merged commit aa803af into 4paradigm:main Mar 28, 2024
31 checks passed
@aceforeverd aceforeverd deleted the fix-makemergenode branch March 28, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-server execute-engine hybridse sql engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants