Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Broken SSH Sessions #12

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Handle Broken SSH Sessions #12

merged 3 commits into from
Aug 1, 2024

Conversation

Deleh
Copy link
Contributor

@Deleh Deleh commented Jul 31, 2024

features

  • Resets SSHClient() objects if a command failed
  • Send an initial echo to LinuxHosts when waiting for the host
  • Seperate the SSH port explicitly from the port check, follow-up/fix of Allow Different SSH Ports #4

@Deleh Deleh force-pushed the feature/handle_broken_ssh_sessions branch 2 times, most recently from 683616d to c92f177 Compare July 31, 2024 17:17
@fmessmer fmessmer requested a review from benmaidel August 1, 2024 10:45
@Deleh Deleh force-pushed the feature/handle_broken_ssh_sessions branch from c92f177 to 109ee8d Compare August 1, 2024 10:46
benmaidel
benmaidel approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@benmaidel benmaidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fmessmer
fmessmer approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@fmessmer fmessmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in emulation

@fmessmer fmessmer merged commit 42eac21 into 4am-robotics:main Aug 1, 2024
1 check passed
@Deleh Deleh deleted the feature/handle_broken_ssh_sessions branch August 13, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmessmer fmessmer fmessmer approved these changes

@benmaidel benmaidel benmaidel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Deleh @benmaidel @fmessmer