Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify parameter structure ConstraintParams #156

Merged
merged 6 commits into from
Apr 21, 2017
Merged

simplify parameter structure ConstraintParams #156

merged 6 commits into from
Apr 21, 2017

Conversation

fmessmer
Copy link
Contributor

include #155
(merge first then rebase this PR)

related to #152

@ipa-bfb please review
@ipa-fxm-cm FYI

@fmessmer fmessmer force-pushed the simplify_parameter_structure_constraints branch from a6923f2 to 1325dbf Compare April 14, 2017 12:46
@fmessmer fmessmer requested a review from bbrito April 20, 2017 11:47
@fmessmer
Copy link
Contributor Author

@ipa-bfb please review

bbrito
bbrito approved these changes Apr 20, 2017
View reviewed changes
Copy link
Contributor

@bbrito bbrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me. I test it and it worked.

The simplification of the constraints looks good.

@fmessmer fmessmer merged commit a7f3aaf into 4am-robotics:indigo_dev Apr 21, 2017
@fmessmer fmessmer deleted the simplify_parameter_structure_constraints branch April 21, 2017 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbrito bbrito bbrito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmessmer @bbrito