Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Mattermost 10.0.0 #585

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Support Mattermost 10.0.0 #585

merged 2 commits into from
Sep 18, 2024

Conversation

dfskoll
Copy link
Contributor

@dfskoll dfskoll commented Sep 18, 2024

This is a simple patch that enables support for Mattermost 10.

Closes #584

Copy link
Collaborator

@hloeung hloeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hloeung hloeung merged commit ec4b62f into 42wim:master Sep 18, 2024
4 checks passed
@dfskoll
Copy link
Contributor Author

dfskoll commented Sep 18, 2024

Thanks!

@micah
Copy link

micah commented Oct 18, 2024

I wonder if there should be a release tag for this support?

@dfskoll
Copy link
Contributor Author

dfskoll commented Oct 18, 2024

Since there is a workaround (#541) I don't think it's worth making a release just for this fix.

@micah
Copy link

micah commented Oct 18, 2024 via email

@kkofler
Copy link

kkofler commented Nov 4, 2024

IMHO, there should be a new release for this change. At least as long as ignoreserverversion is false by default.

I have now set ignoreserverversion=true in my deployment, and I will keep it that way, at least as long as matterircd does not make timely releases for new Mattermost versions. (This one has been sitting there for 2 months now.) But at that point, if the recommendation is for everyone to just enable ignoreserverversion, I wonder why there is a version check at all and why it is enabled by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken on Mattermost 10?
4 participants