Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker base image updates #44

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Conversation

BWibo
Copy link
Member

@BWibo BWibo commented Nov 15, 2024

Update Docker base images to latest Java LTS v21 and latest Ubuntu.

@clausnagel
Do you recall if there was a specific reason why we choose jdk for the runtime image? Is the JDK a requirement for the tool at runtime? If no, we could save ~2/3 of the image size.

I tested to run the tool (no import or export operation), there were no errors.

@BWibo BWibo added the enhancement New feature or request label Nov 15, 2024
@BWibo BWibo self-assigned this Nov 15, 2024
@BWibo BWibo force-pushed the feature/docker-java-lts-update branch from b9e54a3 to f0e9c4d Compare November 15, 2024 09:32
@BWibo BWibo changed the title Feature/docker java lts update Docker base image updates Nov 15, 2024
@clausnagel
Copy link
Member

Well, no, I can't remember. Let me also do some tests and post updates here.

@clausnagel
Copy link
Member

clausnagel commented Nov 15, 2024

Hi @BWibo, I cannot build a Docker image using the adapted Dockerfile. See the errors in the screenshot below. Can you reproduce these errors on your test machine? All works fine in main branch though.

image

@BWibo
Copy link
Member Author

BWibo commented Nov 16, 2024

Oh yes, I didn't expect that and didn't test it.
The 21-jre-noble baseimage already has a user ubuntu with uid, gid 1000 resulting in a conflict. This is actually a good thing, as it saves us the creation of a user. I don't see any issues, if the tools runs as ubuntu and not citydb-tool user, as only uid and gid are relevant. I simplyified the image, it should build now.

@clausnagel clausnagel merged commit 926b84e into main Nov 18, 2024
4 checks passed
@clausnagel clausnagel deleted the feature/docker-java-lts-update branch November 18, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants