Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refact(KtTable): cleanup of unfinished/unused filter feature #847

Closed
wants to merge 1 commit into from
Closed

refact(KtTable): cleanup of unfinished/unused filter feature #847

wants to merge 1 commit into from

Conversation

carsoli
Copy link
Contributor

@carsoli carsoli commented Dec 4, 2023

authored-by: Florian Wendelborn [email protected]

@carsoli carsoli self-assigned this Dec 4, 2023
@carsoli
Copy link
Contributor Author

carsoli commented Dec 4, 2023

needs reviving

@github-actions github-actions bot added the package:kotti-ui @3yourmind/kotti-ui label Dec 4, 2023
Isokaeder
Isokaeder requested changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@Isokaeder Isokaeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjust types in packages/kotti-ui/source/kotti-table/types.ts:

  • Column.Filtered can go
  • references to filteredColumns can go

@carsoli
Copy link
Contributor Author

carsoli commented Dec 4, 2023

Adjust types in packages/kotti-ui/source/kotti-table/types.ts:

  • Column.Filtered can go
  • references to filteredColumns can go

will do

this was an old branch, I'm opening to handle legacy fixes before blocking further things, I'll draft for now, please ignore it

@carsoli carsoli marked this pull request as draft December 4, 2023 16:24
@Isokaeder Isokaeder force-pushed the master branch 6 times, most recently from db0f2aa to 78dbab4 Compare May 14, 2024 14:20
@Isokaeder
Copy link
Collaborator

superseded by #1008

@Isokaeder Isokaeder closed this Oct 24, 2024
@Isokaeder Isokaeder deleted the remove-filter-feature branch October 24, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isokaeder Isokaeder Isokaeder requested changes

@FlorianWendelborn FlorianWendelborn Awaiting requested review from FlorianWendelborn

Assignees

@carsoli carsoli

Labels
package:kotti-ui @3yourmind/kotti-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carsoli @Isokaeder