-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make functions public #120
Comments
Good Input! +1 |
Hi, @HolgerSchulz and @phoebusryan, sure we can go ahead expose that function! It doesn't look like much of the other internal functions would be valuable to be exposed but I'm open to it if either of you has any other requests? |
Sounds good! I think eventhandlers for moving the handle would be very nice. This was an input of one of my customers and I had to change your file to to this. see here: https://bohnenstueck.ch/ |
@phoebusryan Here's the proposed PR: https://github.com/zurb/twentytwenty/pull/122/files New Public Functions:
New Public events:
|
Ah, very nice. I will check it. |
Hi,
I have seen that many people did not immediately realize that you can move the slider with the mouse/finger.
Therefore I added a small animation and a hint. See:
https://www.unser-hueckeswagen.de/Fotos/Schloss-Hueckeswagen.html
Unfortunately I had to patch the JavaScript code for this because I had to access adjustSlider.
If there is an update, it would be nice if you could access the functions like adjustSlider from outside.
Thanks
Holger
P.S. Thanks for this great lib!!!
The text was updated successfully, but these errors were encountered: