Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.5 - Implement lightwalletd gRPC functionality in Rust using JSONRPC interface for backwards compatibility. #52

Closed
1 task
idky137 opened this issue Sep 10, 2024 · 1 comment
Assignees
Labels
tracking V1.0 Required for Zaino V1.0 ZGM1 Issues that need to be resolved for the completion of the Zaino dev grant milestone 1

Comments

@idky137
Copy link
Contributor

idky137 commented Sep 10, 2024

Currently Zaino only has the subset of lightwallet gRPC services that Zingolib uses implemented. The full set of services should be implemented in Zaino-Fetch (backed by Zebra's JsonRPC Service) for backwards compatibility. The deprecated services can then use these implementations until they are fully removed.

Tasks

NOTE 1: Currently compact blocks are fetched as full blocks are parsed to compact blocks before being served to the client. This is inefficient and compact block should be served directly from disc / memory. This work will be completed in #55.

NOTE 2: Currently Lightwalletd does not return the correct error types from its gRPC services [https://github.com/zcash/lightwalletd/issues/497]. We will implement Zaino to use the correct tonic statuses [https://github.com/grpc/grpc/blob/master/doc/statuscodes.md#status-codes-and-their-use-in-grpc] rather than implement functionality as it is in Lightwalletd.

@idky137
Copy link
Contributor Author

idky137 commented Nov 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracking V1.0 Required for Zaino V1.0 ZGM1 Issues that need to be resolved for the completion of the Zaino dev grant milestone 1
Projects
Status: Done
Development

No branches or pull requests

2 participants