Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when importing GroupTypeString #12

Open
giovannipizzi opened this issue Jun 11, 2021 · 1 comment
Open

Issue when importing GroupTypeString #12

giovannipizzi opened this issue Jun 11, 2021 · 1 comment

Comments

@giovannipizzi
Copy link

When I run (locally) the tests for the aiida-common-workflows, I get this:

_______________________________________ ERROR collecting tests/workflows/relax/test_castep.py ________________________________________
ImportError while importing test module '/Users/pizzi/git/aiida-common-workflows/tests/workflows/relax/test_castep.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/local/opt/[email protected]/Frameworks/Python.framework/Versions/3.8/lib/python3.8/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/workflows/relax/test_castep.py:11: in <module>
    from aiida_castep.data.otfg import OTFGGroup
../../.virtualenvs/aiida-dev/lib/python3.8/site-packages/aiida_castep/data/__init__.py:8: in <module>
    from .otfg import OTFGData
../../.virtualenvs/aiida-dev/lib/python3.8/site-packages/aiida_castep/data/otfg.py:11: in <module>
    from .usp import UspData
../../.virtualenvs/aiida-dev/lib/python3.8/site-packages/aiida_castep/data/usp.py:9: in <module>
    from aiida.orm import GroupTypeString
E   ImportError: cannot import name 'GroupTypeString' from 'aiida.orm' (/Users/pizzi/git/aiida-core/aiida/orm/__init__.py)

that seems to come from your code.
Can you please fix it (if not done already)?

(AiiDA version 1.6.2, aiida-castep==1.2.0a5)

@zhubonan
Copy link
Owner

zhubonan commented Oct 5, 2021

Woops. Thanks for the report. That was some very old import state for aiida-core1.0b compatibility.... I have now removed it on the dev branch and it should work. Probably need to make a new release at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants