Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Jinja2 processing during metrics export to Prometheus #306

Open
andy-maier opened this issue Mar 28, 2023 · 0 comments
Open

Optimize Jinja2 processing during metrics export to Prometheus #306

andy-maier opened this issue Mar 28, 2023 · 0 comments
Labels
area: code type: enhancement New feature or request
Milestone

Comments

@andy-maier
Copy link
Member

Currently, the Jinja2 expressions for labels in the metric definition file are parsed each time Prometheus retrieves metrics from the exporter.

This should be optimized, e.g. by compiling the Jinja2 expressions so that the Jinja2 parsing is done only once. The evaluation of the Jinja2 expressions cannot be done just once, because it way include other metrics or property values.

@andy-maier andy-maier self-assigned this Mar 28, 2023
@andy-maier andy-maier added type: enhancement New feature or request area: code labels Mar 28, 2023
@andy-maier andy-maier added this to the 1.5.0 milestone Mar 28, 2023
@andy-maier andy-maier modified the milestones: 1.5.0, 1.6.0 Nov 9, 2023
@andy-maier andy-maier removed their assignment Jan 12, 2024
@andy-maier andy-maier modified the milestones: 1.6.0, 1.7.0 Apr 2, 2024
@andy-maier andy-maier modified the milestones: 1.7.0, 2.0.0 Jul 29, 2024
@andy-maier andy-maier modified the milestones: 2.0.0, 2.1.0 Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: code type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant