You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 15, 2023. It is now read-only.
The deployment logic should be replaced with a single script that handles each network properly and will properly deploy mocks/test fixtures for the test suite to run, when the deployment is using hardhat network. Deployments should --export-all to deployments/deployments.json and applications which depend on imports from the singular JSON files need to be adjusted to import only from deployments/deployments.json (zero-app/zeroBRIDGE)
npm scripts should be rewritten to use --export-all properly. If there's a way to do it in the hardhat runtime directly without needing to supply this flag, so the --export-all behavior will occur on yarn hardhat node, then implement it in the hardhat config file instead.
After revisions, console output should be clear and demonstrate each step of the process in a way that is concise and easy to understand for the developer
All calls to deploy should be replaced with deployIfDifferent so there is no more inconsistency in a deploy process. It should all be handled by yarn deploy when a deployment is needed.
The text was updated successfully, but these errors were encountered:
The deployment logic should be replaced with a single script that handles each network properly and will properly deploy mocks/test fixtures for the test suite to run, when the deployment is using hardhat network. Deployments should --export-all to deployments/deployments.json and applications which depend on imports from the singular JSON files need to be adjusted to import only from deployments/deployments.json (zero-app/zeroBRIDGE)
npm scripts should be rewritten to use --export-all properly. If there's a way to do it in the hardhat runtime directly without needing to supply this flag, so the --export-all behavior will occur on
yarn hardhat node
, then implement it in the hardhat config file instead.After revisions, console output should be clear and demonstrate each step of the process in a way that is concise and easy to understand for the developer
All calls to deploy should be replaced with deployIfDifferent so there is no more inconsistency in a deploy process. It should all be handled by
yarn deploy
when a deployment is needed.The text was updated successfully, but these errors were encountered: