net: wifi: Fix CONFIG_EAP_TTLS not enabling all dependencies #82309
Conversation
zephyrbot
added
area: Wi-Fi
modules/hostap/CMakeLists.txt
Outdated
| @@ -398,6 +398,7 @@ zephyr_library_compile_definitions_ifdef(CONFIG_EAP_TLS | |||
|
|
|||
| zephyr_library_sources_ifdef(CONFIG_EAP_TTLS | |||
| ${HOSTAP_SRC_BASE}/eap_peer/eap_ttls.c | |||
| ${HOSTAP_SRC_BASE}/eap_common/chap.c | |||
There was a problem hiding this comment.
to avoid adding twice, maybe we can do something like:
if(CONFIG_EAP_TTLS OR CONFIG_EAP_MSCHAPV2)
zephyr_library_sources( ${HOSTAP_SRC_BASE}/eap_common/chap.c)
endif()
There was a problem hiding this comment.
Hi @krish2718
TTLS and MSCHAPV2 are separated EPA security types. Should we keep the original config, but not add this change?
If want to support EAP-TTLS-MSCHAPv2, we should enable both EAP-TTLS macro and EAP-MSCHAPV2 macros, is this will be more reasonable?
What my concern is TTLS for pharse1 and MSCHAPV2 for pharse2, there may be so many sets for different pharse1 and pharse2, so can we still make it configured independent?
This comment also apply for EAP-PEAP-MSCHAPv2.
There was a problem hiding this comment.
Sure, but my suggested fix is a or b, so, chap.c would be includes in that case, no?
There was a problem hiding this comment.
EAP-TTLS is independent with MSCHAPV2.
EAP-TTLS can also combine with other pharse2 EAP type, in this case, eap_common/chap.c will be build in application, but not used.
TjazVracko
force-pushed
the
fix/wifi-eap-ttls
branch
2 times, most recently
from
f252147
to
7468ec8
Compare
modules/hostap/CMakeLists.txt
Outdated
| ) | ||
|
|
||
| zephyr_library_compile_definitions_ifdef(CONFIG_EAP_MSCHAPV2 | ||
| EAP_MSCHAPv2 | ||
| ) | ||
|
|
||
| if(CONFIG_EAP_TTLS OR CONFIG_EAP_MSCHAPV2) | ||
| zephyr_library_sources( ${HOSTAP_SRC_BASE}/eap_common/chap.c) |
There was a problem hiding this comment.
| zephyr_library_sources( ${HOSTAP_SRC_BASE}/eap_common/chap.c) | |
| zephyr_library_sources(${HOSTAP_SRC_BASE}/eap_common/chap.c) |
CONFIG_EAP_TTLS now correctly adds all .c files it requires from hostap. Signed-off-by: Tjaž Vračko <[email protected]>
TjazVracko
force-pushed
the
fix/wifi-eap-ttls
branch
from
7468ec8
to
79f5459
Compare
CONFIG_EAP_TTLS now correctly adds all .c files it requires from hostap.
Related: #82098