Bluetooth: CCP: Introduce new CCP API #77120
Open
+1,758
−230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
ccp_register
branch
3 times, most recently
from
6aa67a6
to
63398a4
Compare
Thalley
force-pushed
the
ccp_register
branch
6 times, most recently
from
4599b32
to
fc5da98
Compare
Thalley
commented
Aug 28, 2024
include/zephyr/bluetooth/audio/ccp.h
Outdated
Comment on lines
66
to
71
| int bt_ccp_server_register_bearer(const struct bt_tbs_register_param *param, | ||
| struct bt_ccp_server_bearer **bearer); |
There was a problem hiding this comment.
For reviewers: I consider the following naming options:
- bt_ccp_ccs (Bluetooth Call Control Profile Call Control Server, where Call Control Server is the actual name of the role in CCP)
- bt_ccp_call_control_server (more verbose version of the above; naming similar to e.g. bt_bap_unicast_server)
- bt_ccp_call_ctrl_srv (shorter version of 3, more similar to the VCP and MICP APIs (e.g. bt_vcp_vol_rend)
- bt_ccp_server (and in upcoming PRs, bt_ccp_client).
If you have any preferences or other suggestions, please let me know and we can just do a rename
There was a problem hiding this comment.
I prefer 3. bt_ccp_call_control_server. It is easier to spelling and understand.
There was a problem hiding this comment.
Thanks for your input - Other reviews please also comment here about what you prefer
There was a problem hiding this comment.
No strong preferences, but I do in general prefer longer, more readable names.
There was a problem hiding this comment.
@koffes is that a vote for 3) then?
Thalley
force-pushed
the
ccp_register
branch
4 times, most recently
from
87437d8
to
1e8dcd7
Compare
Thalley
force-pushed
the
ccp_register
branch
6 times, most recently
from
87a92cf
to
3c73258
Compare
Thalley
force-pushed
the
ccp_register
branch
9 times, most recently
from
0ede37d
to
c3c5f3f
Compare
Thalley
force-pushed
the
ccp_register
branch
3 times, most recently
from
90f3646
to
c53b52c
Compare
Thalley
force-pushed
the
ccp_register
branch
from
c53b52c
to
62367c9
Compare
kruithofa
reviewed
Nov 22, 2024
| gtbs}>] | ||
|
|
||
|
|
||
| In the following examples, notifications from GTBS is ignored, unless otherwise |
There was a problem hiding this comment.
Suggested change
| In the following examples, notifications from GTBS is ignored, unless otherwise | |
| In the following examples, notifications from GTBS are ignored, unless otherwise |
This was also wrong in the original document, but suggest to fix it here
Thalley
force-pushed
the
ccp_register
branch
from
62367c9
to
844a3e1
Compare
Thalley
force-pushed
the
ccp_register
branch
from
844a3e1
to
4c8106b
Compare
larsgk
requested changes
Nov 25, 2024
| ******** | ||
|
|
||
| Application demonstrating the CCP Server functionality. | ||
| Starts by advertising for a CCP Clients to connect and set up calls. |
There was a problem hiding this comment.
Suggested change
| Starts by advertising for a CCP Clients to connect and set up calls. | |
| Starts by advertising for CCP Clients to connect and set up calls. |
| ************ | ||
|
|
||
| * BlueZ running on the host, or | ||
| * A board with Bluetooth Low Energy 5.2 support |
There was a problem hiding this comment.
5.3 is not required :)
| } | ||
| } | ||
|
|
||
| if (adv != NULL) { |
There was a problem hiding this comment.
maybe make sure adv is 0 on init
Thalley
force-pushed
the
ccp_register
branch
2 times, most recently
from
067ce29
to
2563cf7
Compare
|
Renamed to Call Control Profile Call Control Server as per #77120 (comment) and short discussion in the weekly LE Audio meeting |
Thalley
force-pushed
the
ccp_register
branch
2 times, most recently
from
fc12d63
to
d5b6e68
Compare
The CCP API for the Call Control Profile works on top of the TBS API, and will eventually replace parts of the TBS API. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
ccp_register
branch
from
d5b6e68
to
6bc5e73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CCP API for the Call Control Profile works on top of the
TBS API, and will eventually replace parts of the TBS API.
Signed-off-by: Emil Gydesen [email protected]