pm: policy: latency: Add support for immediate action #162360
Annotations
3 errors, 2 warnings, and 6 notices
|
Run Compliance Tests
Process completed with exit code 2.
|
|
check-warns:
Checkpatch.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details.
BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
File:include/zephyr/pm/policy.h
Line:80
|
|
check-warns
Process completed with exit code 1.
|
|
Run Compliance Tests:
include/zephyr/pm/policy.h#L80
include/zephyr/pm/policy.h:80 Block comments use a trailing */ on a separate line
|
|
check-warns:
ClangFormat.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
You may want to run clang-format on this change:
-static inline int pm_policy_latency_request_add(
- struct pm_policy_latency_request *req, uint32_t value_us)
+static inline int pm_policy_latency_request_add(struct pm_policy_latency_request *req,
+ uint32_t value_us)
{
ARG_UNUSED(req);
ARG_UNUSED(value_us);
return 0;
}
-static inline int pm_policy_latency_request_update(
- struct pm_policy_latency_request *req, uint32_t value_us)
+static inline int pm_policy_latency_request_update(struct pm_policy_latency_request *req,
+ uint32_t value_us)
{
ARG_UNUSED(req);
ARG_UNUSED(value_us);
return 0;
}
-static inline int pm_policy_latency_request_remove(
- struct pm_policy_latency_request *req)
+static inline int pm_policy_latency_request_remove(struct pm_policy_latency_request *req)
File:include/zephyr/pm/policy.h
Line:393
You may want to run clang-format on this change:
- max_latency_cyc = max_latency_us != SYS_FOREVER_US ?
- (int32_t)k_us_to_cyc_ceil32(max_latency_us) : -1;
+ max_latency_cyc = max_latency_us != SYS_FOREVER_US
+ ? (int32_t)k_us_to_cyc_ceil32(max_latency_us)
+ : -1;
File:subsys/pm/policy/policy_latency.c
Line:36
You may want to run clang-format on this change:
- return onoff_request(immediate_mgr.bin_mgr->mgr, &req->cli) == ONOFF_STATE_ON ?
- 0 : 1;
+ return onoff_request(immediate_mgr.bin_mgr->mgr, &req->cli) == ONOFF_STATE_ON ? 0
+ : 1;
} else if (req->value_us > thr && prev <= thr) {
return onoff_cancel_or_release(immediate_mgr.bin_mgr->mgr, &req->cli) ==
- ONOFF_STATE_ON ? 0 : 1;
+ ONOFF_STATE_ON
+ ? 0
+ : 1;
File:subsys/pm/policy/policy_latency.c
Line:90
You may want to run clang-format on this change:
- struct k_poll_event evt = K_POLL_EVENT_INITIALIZER(K_POLL_TYPE_SIGNAL,
- K_POLL_MODE_NOTIFY_ONLY,
- &sig);
+ struct k_poll_event evt =
+ K_POLL_EVENT_INITIALIZER(K_POLL_TYPE_SIGNAL, K_POLL_MODE_NOTIFY_ONLY, &sig);
File:subsys/pm/policy/policy_latency.c
Line:147
You may want to run clang-format on this change:
-static void onoff_monitor_cb(struct onoff_manager *mgr,
- struct onoff_monitor *mon,
- uint32_t state,
+static void onoff_monitor_cb(struct onoff_manager *mgr, struct onoff_monitor *mon, uint32_t state,
File:tests/subsys/pm/policy_api/src/main.c
Line:266
You may want to run clang-format on this change:
- static const struct onoff_transitions transitions = {
- .start = onoff_start,
- .stop = onoff_stop
- };
+ static const struct onoff_transitions transitions = {.start = onoff_start,
+ .stop = onoff_stop};
File:tests/subsys/pm/policy_api/src/main.c
Line:304
|
|
Run Compliance Tests:
include/zephyr/pm/policy.h#L393
include/zephyr/pm/policy.h:393
-static inline int pm_policy_latency_request_add(
- struct pm_policy_latency_request *req, uint32_t value_us)
+static inline int pm_policy_latency_request_add(struct pm_policy_latency_request *req,
+ uint32_t value_us)
{
ARG_UNUSED(req);
ARG_UNUSED(value_us);
return 0;
}
-static inline int pm_policy_latency_request_update(
- struct pm_policy_latency_request *req, uint32_t value_us)
+static inline int pm_policy_latency_request_update(struct pm_policy_latency_request *req,
+ uint32_t value_us)
{
ARG_UNUSED(req);
ARG_UNUSED(value_us);
return 0;
}
-static inline int pm_policy_latency_request_remove(
- struct pm_policy_latency_request *req)
+static inline int pm_policy_latency_request_remove(struct pm_policy_latency_request *req)
|
|
Run Compliance Tests:
subsys/pm/policy/policy_latency.c#L36
subsys/pm/policy/policy_latency.c:36
- max_latency_cyc = max_latency_us != SYS_FOREVER_US ?
- (int32_t)k_us_to_cyc_ceil32(max_latency_us) : -1;
+ max_latency_cyc = max_latency_us != SYS_FOREVER_US
+ ? (int32_t)k_us_to_cyc_ceil32(max_latency_us)
+ : -1;
|
|
Run Compliance Tests:
subsys/pm/policy/policy_latency.c#L90
subsys/pm/policy/policy_latency.c:90
- return onoff_request(immediate_mgr.bin_mgr->mgr, &req->cli) == ONOFF_STATE_ON ?
- 0 : 1;
+ return onoff_request(immediate_mgr.bin_mgr->mgr, &req->cli) == ONOFF_STATE_ON ? 0
+ : 1;
} else if (req->value_us > thr && prev <= thr) {
return onoff_cancel_or_release(immediate_mgr.bin_mgr->mgr, &req->cli) ==
- ONOFF_STATE_ON ? 0 : 1;
+ ONOFF_STATE_ON
+ ? 0
+ : 1;
|
|
Run Compliance Tests:
subsys/pm/policy/policy_latency.c#L147
subsys/pm/policy/policy_latency.c:147
- struct k_poll_event evt = K_POLL_EVENT_INITIALIZER(K_POLL_TYPE_SIGNAL,
- K_POLL_MODE_NOTIFY_ONLY,
- &sig);
+ struct k_poll_event evt =
+ K_POLL_EVENT_INITIALIZER(K_POLL_TYPE_SIGNAL, K_POLL_MODE_NOTIFY_ONLY, &sig);
|
|
Run Compliance Tests:
tests/subsys/pm/policy_api/src/main.c#L266
tests/subsys/pm/policy_api/src/main.c:266
-static void onoff_monitor_cb(struct onoff_manager *mgr,
- struct onoff_monitor *mon,
- uint32_t state,
+static void onoff_monitor_cb(struct onoff_manager *mgr, struct onoff_monitor *mon, uint32_t state,
|
|
Run Compliance Tests:
tests/subsys/pm/policy_api/src/main.c#L304
tests/subsys/pm/policy_api/src/main.c:304
- static const struct onoff_transitions transitions = {
- .start = onoff_start,
- .stop = onoff_stop
- };
+ static const struct onoff_transitions transitions = {.start = onoff_start,
+ .stop = onoff_stop};
|
Loading