Bluetooth: Host: Deprecate BT_BUF_ACL_RX_COUNT
symbol
#161991
Annotations
1 error, 1 warning, and 5 notices
Run Compliance Tests
Process completed with exit code 1.
|
check-warns:
ClangFormat.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
You may want to run clang-format on this change:
-#define BT_BUF_ACL_RX_COUNT_MAX 65535
+#define BT_BUF_ACL_RX_COUNT_MAX 65535
#define BT_BUF_ACL_RX_COUNT_DEFAULT 6
#if defined(CONFIG_BT_CONN) && defined(CONFIG_BT_HCI_HOST)
- /* The host needs more ACL buffers than maximum ACL links. This is because of
- * the way we re-assemble ACL packets into L2CAP PDUs.
- *
- * We keep around the first buffer (that comes from the driver) to do
- * re-assembly into, and if all links are re-assembling, there will be no buffer
- * available for the HCI driver to allocate from.
- *
- * Fixing it properly involves a re-design of the HCI driver interface.
- *
- * TODO: When CONFIG_BT_BUF_ACL_RX_COUNT is removed,
- * remove the MAX and only keep (CONFIG_BT_MAX_CONN + 1)
- */
-#define BT_BUF_ACL_RX_COUNT (MAX(CONFIG_BT_BUF_ACL_RX_COUNT, (CONFIG_BT_MAX_CONN + 1)) + \
- CONFIG_BT_BUF_ACL_RX_COUNT_EXTRA)
+/* The host needs more ACL buffers than maximum ACL links. This is because of
+ * the way we re-assemble ACL packets into L2CAP PDUs.
+ *
+ * We keep around the first buffer (that comes from the driver) to do
+ * re-assembly into, and if all links are re-assembling, there will be no buffer
+ * available for the HCI driver to allocate from.
+ *
+ * Fixing it properly involves a re-design of the HCI driver interface.
+ *
+ * TODO: When CONFIG_BT_BUF_ACL_RX_COUNT is removed,
+ * remove the MAX and only keep (CONFIG_BT_MAX_CONN + 1)
+ */
+#define BT_BUF_ACL_RX_COUNT \
+ (MAX(CONFIG_BT_BUF_ACL_RX_COUNT, (CONFIG_BT_MAX_CONN + 1)) + \
+ CONFIG_BT_BUF_ACL_RX_COUNT_EXTRA)
File:include/zephyr/bluetooth/buf.h
Line:107
You may want to run clang-format on this change:
-#define BT_BUF_RX_COUNT (MAX(MAX(CONFIG_BT_BUF_EVT_RX_COUNT, \
- BT_BUF_ACL_RX_COUNT), \
- BT_BUF_ISO_RX_COUNT))
+#define BT_BUF_RX_COUNT \
+ (MAX(MAX(CONFIG_BT_BUF_EVT_RX_COUNT, BT_BUF_ACL_RX_COUNT), BT_BUF_ISO_RX_COUNT))
File:include/zephyr/bluetooth/buf.h
Line:122
You may want to run clang-format on this change:
-NET_BUF_POOL_DEFINE(acl_in_pool, BT_BUF_ACL_RX_COUNT,
- BT_BUF_ACL_SIZE(CONFIG_BT_BUF_ACL_RX_SIZE),
+NET_BUF_POOL_DEFINE(acl_in_pool, BT_BUF_ACL_RX_COUNT, BT_BUF_ACL_SIZE(CONFIG_BT_BUF_ACL_RX_SIZE),
File:subsys/bluetooth/host/buf.c
Line:45
You may want to run clang-format on this change:
-#define RFCOMM_MAX_CREDITS (BT_BUF_ACL_RX_COUNT - 1)
+#define RFCOMM_MAX_CREDITS (BT_BUF_ACL_RX_COUNT - 1)
File:subsys/bluetooth/host/classic/rfcomm.c
Line:41
You may want to run clang-format on this change:
-#define L2CAP_LE_MAX_CREDITS (BT_BUF_ACL_RX_COUNT - 1)
+#define L2CAP_LE_MAX_CREDITS (BT_BUF_ACL_RX_COUNT - 1)
File:subsys/bluetooth/host/l2cap.c
Line:47
|
Run Compliance Tests:
include/zephyr/bluetooth/buf.h#L107
include/zephyr/bluetooth/buf.h:107
-#define BT_BUF_ACL_RX_COUNT_MAX 65535
+#define BT_BUF_ACL_RX_COUNT_MAX 65535
#define BT_BUF_ACL_RX_COUNT_DEFAULT 6
#if defined(CONFIG_BT_CONN) && defined(CONFIG_BT_HCI_HOST)
- /* The host needs more ACL buffers than maximum ACL links. This is because of
- * the way we re-assemble ACL packets into L2CAP PDUs.
- *
- * We keep around the first buffer (that comes from the driver) to do
- * re-assembly into, and if all links are re-assembling, there will be no buffer
- * available for the HCI driver to allocate from.
- *
- * Fixing it properly involves a re-design of the HCI driver interface.
- *
- * TODO: When CONFIG_BT_BUF_ACL_RX_COUNT is removed,
- * remove the MAX and only keep (CONFIG_BT_MAX_CONN + 1)
- */
-#define BT_BUF_ACL_RX_COUNT (MAX(CONFIG_BT_BUF_ACL_RX_COUNT, (CONFIG_BT_MAX_CONN + 1)) + \
- CONFIG_BT_BUF_ACL_RX_COUNT_EXTRA)
+/* The host needs more ACL buffers than maximum ACL links. This is because of
+ * the way we re-assemble ACL packets into L2CAP PDUs.
+ *
+ * We keep around the first buffer (that comes from the driver) to do
+ * re-assembly into, and if all links are re-assembling, there will be no buffer
+ * available for the HCI driver to allocate from.
+ *
+ * Fixing it properly involves a re-design of the HCI driver interface.
+ *
+ * TODO: When CONFIG_BT_BUF_ACL_RX_COUNT is removed,
+ * remove the MAX and only keep (CONFIG_BT_MAX_CONN + 1)
+ */
+#define BT_BUF_ACL_RX_COUNT \
+ (MAX(CONFIG_BT_BUF_ACL_RX_COUNT, (CONFIG_BT_MAX_CONN + 1)) + \
+ CONFIG_BT_BUF_ACL_RX_COUNT_EXTRA)
|
Run Compliance Tests:
include/zephyr/bluetooth/buf.h#L122
include/zephyr/bluetooth/buf.h:122
-#define BT_BUF_RX_COUNT (MAX(MAX(CONFIG_BT_BUF_EVT_RX_COUNT, \
- BT_BUF_ACL_RX_COUNT), \
- BT_BUF_ISO_RX_COUNT))
+#define BT_BUF_RX_COUNT \
+ (MAX(MAX(CONFIG_BT_BUF_EVT_RX_COUNT, BT_BUF_ACL_RX_COUNT), BT_BUF_ISO_RX_COUNT))
|
Run Compliance Tests:
subsys/bluetooth/host/buf.c#L45
subsys/bluetooth/host/buf.c:45
-NET_BUF_POOL_DEFINE(acl_in_pool, BT_BUF_ACL_RX_COUNT,
- BT_BUF_ACL_SIZE(CONFIG_BT_BUF_ACL_RX_SIZE),
+NET_BUF_POOL_DEFINE(acl_in_pool, BT_BUF_ACL_RX_COUNT, BT_BUF_ACL_SIZE(CONFIG_BT_BUF_ACL_RX_SIZE),
|
Run Compliance Tests:
subsys/bluetooth/host/classic/rfcomm.c#L41
subsys/bluetooth/host/classic/rfcomm.c:41
-#define RFCOMM_MAX_CREDITS (BT_BUF_ACL_RX_COUNT - 1)
+#define RFCOMM_MAX_CREDITS (BT_BUF_ACL_RX_COUNT - 1)
|
Run Compliance Tests:
subsys/bluetooth/host/l2cap.c#L47
subsys/bluetooth/host/l2cap.c:47
-#define L2CAP_LE_MAX_CREDITS (BT_BUF_ACL_RX_COUNT - 1)
+#define L2CAP_LE_MAX_CREDITS (BT_BUF_ACL_RX_COUNT - 1)
|
Loading