You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Testing is done with another implementation of ConstraintSystem
Description: TestConstraintSystem is used throughout testing while ProvingAssignment is used in proving, both implementing the ConstraintSystem trait. While our focus was testing constraints and cryptography, we’d like to note that this is also a potential location of danger - when adding constraints and allocating variables, there could be a different behaviour.
Note that both implementations (here and here) are very simple and short; they are essentially only keeping track of lists of auxiliary variables, inputs, and R1CS constraints. On the other hand, it does seem as though it might be possible to alleviate this concern for future reviews by sharing more code.
The text was updated successfully, but these errors were encountered:
stefandeml
pushed a commit
to stefandeml/sapling-crypto
that referenced
this issue
Jul 5, 2019
From the QED-it report:
Note that both implementations (here and here) are very simple and short; they are essentially only keeping track of lists of auxiliary variables, inputs, and R1CS constraints. On the other hand, it does seem as though it might be possible to alleviate this concern for future reviews by sharing more code.
The text was updated successfully, but these errors were encountered: