Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly define edwards_a? #103

Open
arielgabizon opened this issue Aug 10, 2019 · 0 comments
Open

Explicitly define edwards_a? #103

arielgabizon opened this issue Aug 10, 2019 · 0 comments
Labels
to librustzcash repo

Comments

@arielgabizon
Copy link

https://github.com/zcash-hackworks/sapling-crypto/blob/b70d6e66fc1de66f8609e22a2b13eb11bdeb69b3/src/jubjub/mod.rs#L104

Right now it seems the code implicitly uses a=-1
which assumes -1 is QR if Fr. Might be better to make this explicit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
to librustzcash repo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@str4d @arielgabizon