Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: (low-priority) darkside: RemoveTreeState on non-existent height crashes lightwalletd #466

Open
LarryRuane opened this issue Dec 1, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@LarryRuane
Copy link
Collaborator

This is a minor bug but should be fixed. To reproduce:

$ go run main.go --no-tls-very-insecure --log-file /dev/stdout --darkside-timeout 999999 --darkside-very-insecure

in another window:

$ grpcurl -plaintext -d '{"saplingActivation": 663150,"branchID": "bad", "chainName":"x"}' localhost:9067 cash.z.wallet.sdk.rpc.DarksideStreamer/Reset
$ grpcurl -plaintext -d '{"height": 663150}' localhost:9067 cash.z.wallet.sdk.rpc.DarksideStreamer/RemoveTreeState

It's required to add a tree state at this height first, but not doing so shouldn't crash the server; it should generate a reasonable error message and continue running.

@LarryRuane LarryRuane added the bug Something isn't working label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant