Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Improve helm chart #70

Open
lmolas opened this issue Jul 10, 2023 · 1 comment
Open

[Feature] Improve helm chart #70

lmolas opened this issue Jul 10, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@lmolas
Copy link

lmolas commented Jul 10, 2023 •
edited
Loading

Hello,

I would like to use your helm chart to deploy your aggregation gateway but as it is it can not work for us.
It lacks some flexibility mainly on additional labels for PodMonitor and ServiceMonitor.
For now it is the only blocking thing I see but I will do an exhaustive check.
And also I think that it is better to not use latest tag for your docker image.
I can submit a PR if you want.

Thx
@mplachter
Copy link
Contributor

@lmolas would love a PR for this 🚀

@mplachter mplachter added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lmolas @mplachter