Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeGrad: Adding Covariates as Conditioning Input #169

Open
ClaraGrthns opened this issue Jun 17, 2024 · 4 comments
Open

TimeGrad: Adding Covariates as Conditioning Input #169

ClaraGrthns opened this issue Jun 17, 2024 · 4 comments

Comments

@ClaraGrthns
Copy link
Contributor

Hi there,

I was wondering whether it is possible to add covariates into the conditioning part of the TimeGrad implementation? It seems to me as if the transformations that are done automatically inside the time_grad_estimator for time features and lagged sequences are used as conditioning input, but how could I incorporate further covariates (i.e. of the type FieldName.feat_dynamic_real), that I don't want to forecast.

Thanks in advance!

@kashif
Copy link
Collaborator

kashif commented Jun 17, 2024

so @ClaraGrthns yes the model does take in date-time features and lags as covariates, to add further covariates one can have a look at how that is done for the multivariate setting in the deepAR model in the 0.7.0 branch...

i didn't see the need to add further covaraites in the multivariate setting... even lags are too much as each lag index causes the multivariate dim to go up by the multivariate dim which can be high especially for datasets of multivariate size 2K or more...

also there was no need to add an id for each variate as the order of the variate is kept fixed...

but yeah if you have more covariates for your data, then just concat them to the input vectors as in the deepAR setting...

@2ySong
Copy link

2ySong commented Jun 18, 2024

so @ClaraGrthns yes the model does take in date-time features and lags as covariates, to add further covariates one can have a look at how that is done for the multivariate setting in the deepAR model in the 0.7.0 branch...

i didn't see the need to add further covaraites in the multivariate setting... even lags are too much as each lag index causes the multivariate dim to go up by the multivariate dim which can be high especially for datasets of multivariate size 2K or more...

also there was no need to add an id for each variate as the order of the variate is kept fixed...

but yeah if you have more covariates for your data, then just concat them to the input vectors as in the deepAR setting...

hello,The predictor outputs all nans in the TimeGrad. Could you slove it? thanks.

@SimonTreu
Copy link

@ClaraGrthns did you adapt the TimeGrad implementation to add covariates? I would be interested in that as well.

@ClaraGrthns
Copy link
Contributor Author

@SimonTreu no, in the end, I chose another Time Series Diffusion Model to incorporate future covariates (weather forceasts) into the conditioning input of the denoising network. It definitely improved the point estimates on the target time series, but at the same time it worsened the sample diversity. Have you tried something similar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants