Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names are not pickled/unpickled #206

Open
JBorrow opened this issue Oct 11, 2021 · 3 comments
Open

Names are not pickled/unpickled #206

JBorrow opened this issue Oct 11, 2021 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@JBorrow
Copy link
Contributor

JBorrow commented Oct 11, 2021

The name attribute of the unyt array is not pickled/unpicked. Requires changes to the following methods:

def __reduce__(self):

def __setstate__(self, state):

@ngoldbaum
Copy link
Member

Oops! You’ll also need to make sure you can load both new and old pickle files, failing gracefully for old pickles.

@neutrinoceros
Copy link
Member

I see this issue was opened only 3 days after sympy/sympy#22241
It doesn't look like the exact same issue but since the sympy bug hasn't been fixed upstream yet it's worth noting that it exists for anyone wishing to work on this.

@JBorrow
Copy link
Contributor Author

JBorrow commented Jan 24, 2022

I guess these are fundamentally different issues though, name is an attribute on unyt_array that we are just choosing not to store in the pickle.

@neutrinoceros neutrinoceros added the help wanted Extra attention is needed label Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants