Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnome 45 port #137

Merged
merged 11 commits into from
Nov 12, 2023
Merged

Gnome 45 port #137

merged 11 commits into from
Nov 12, 2023

Conversation

yilozt
Copy link
Owner

@yilozt yilozt commented Oct 14, 2023

Now let's try to move this extension to Gnome 45. This PR do nothing, just update the import declarations for Gnome 45.

Fixes #130

You can help test this PR via open Github Actions: https://github.com/yilozt/rounded-window-corners/actions?query=branch%3Agnome-45-port, then download the extensions that pack from GitHub Actions:

recording_.webm

Then install extensions via:

cd ~/Downloads
gnome-extensions install ./[email protected]  --force

Now you can help to test this extensions in Gnome 45~

Some problems to solve:

  • When you switch workspace via swipe gesture on touch-pad, you will find that shadow of window has gone when the animation running. Because the WorkspaceGroup class has been private in Gnome 45. We can't access it directly anymore. We need find a way to implement this features.
    Or you can install Desktop Cube and switch workspace by drag the desktop, you will find that the shadow we add for window has gone.
  • In ESM, we can't patch a export function directly. so we can't change the behaviour of addBackgroundMenu() , this extensions can't add on popup menu to open preferences page when gnome-shell startup.
  • Use console.log() to logging.
    https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging
  • [ ] Use libadwaita for preferences window ui? will finish this feature when i have free time.
  • Can't load translations.
  • Can't open shadow edit window

@gregor160300
Copy link

I've just tested this on Fedora 39 Beta, and it seems to work as you described, window shadow stay when using the workspace indicator or overview to switch, can't test touchpad switching as this is on desktop. I think libadwaita would be nice to have, but not required.

@yilozt yilozt marked this pull request as ready for review October 16, 2023 18:34
@yilozt yilozt changed the title WIP: Gnome 45 port Gnome 45 port Oct 16, 2023
@veraguido
Copy link

tried it for a few hours already, works like a charm. Thanks!

@ryzendew
Copy link

Works so well i will report any issues

@2k16daniel
Copy link

No issue so far Let's goooo!!!!

@claytonwramsey
Copy link

claytonwramsey commented Oct 18, 2023

Just tested this on Fedora 39 with an NVIDIA GPU. No issues with the extension - the only wrinkle was that I had to restart my shell session before the extension was fully installed. Thanks!

@kir68k
Copy link

kir68k commented Oct 18, 2023

The only wrinkle was that I had to restart my shell session before the extension was fully installed.

This seems to just be how the gnome-extensions command works, not specific to this plugin.
Can confirm on amdgpu this works well now.

@k1gen
Copy link

k1gen commented Oct 18, 2023

thanks, this works without issues for me!

@BobbieERay
Copy link

Thanks so much. Works without issues for me also so far. Just remember to restart gnome-extensions after the install.

@PJansky
Copy link

PJansky commented Oct 20, 2023

I've been using it for the last couple of days, I've seen no regressions

@AlexNabokikh
Copy link

works fine on ubuntu 23.10

@khalangy
Copy link

Works well for me too on Arch gnome 45.
Thanks @yilozt 😄

@Fxsch
Copy link

Fxsch commented Oct 23, 2023

I tested it on Arch GNOME 45 as well and it seems to work perfectly fine

@pixlxip
Copy link

pixlxip commented Oct 26, 2023

Works great for me... ArcoLinux, Gnome 45

@hsantos92
Copy link

This works for me. Arch, Gnome 45 👍🏼

@sidevesh
Copy link

sidevesh commented Oct 26, 2023

works for me too on Arch, @yilozt can you rebase and get https://github.com/yilozt/rounded-window-corners/tree/rounded-all-windows-in-overview branch in before pushing this to gnome extensions and close #93 ?
I have been manually installing the version on that branch for quite some time but I wasn't able to rebase it on this pr and would really like to get the windows rounded in overview feature in the main branch and release so I can stop installing / maintaining the version on the branch

@lolcatswag
Copy link

Works really good for me! tysm!!!! Fedora 39 Beta

@acerspyro
Copy link

Works great, thank you!

@joax
Copy link

joax commented Nov 2, 2023

Ubuntu 23.10 tested, works like a charm here.

@mbeps
Copy link

mbeps commented Nov 5, 2023

Thanks, now almost all the extensions that I like are on Gnome 45. Maybe by the time Fedora 39 is out, all my extensions would have been ported.

@Chillsmeit
Copy link

OpenSUSE Tumbleweed using Gnome 45, been using it for a week now. Works like a charm, 0 issues so far.

@jonhteper
Copy link

Tested on Manjaro Gnome 45, and woks without issues. Thanks for all.

@rezzubs
Copy link

rezzubs commented Nov 7, 2023

Used the gnome 45 version for a few weeks now, no issues.

@anhng195
Copy link

anhng195 commented Nov 7, 2023

Please release it on the extension store

@DavidWoli
Copy link

@yilozt Could you please merge it and release it on the extension store? Please...

@yilozt
Copy link
Owner Author

yilozt commented Nov 8, 2023 via email

@sidevesh
Copy link

sidevesh commented Nov 8, 2023

@yilozt Can you take a look at #137 (comment) please ?

@yilozt
Copy link
Owner Author

yilozt commented Nov 8, 2023 via email

@yilozt yilozt merged commit 6d49a3e into main Nov 12, 2023
3 checks passed
@saschaeggi
Copy link

I can confirm that using https://github.com/yilozt/rounded-window-corners/actions/runs/6839498020 works on Fedora 39 with Gnome 45

@AlexNabokikh
Copy link

@yilozt Can you release a new version so we can install it via GNOME extensions instead of manually using GitHub artifacts? Thank you!

@Majklovitch
Copy link

Apparently the Artifact expired and it's no longer for download. Is there a way I can get it?

@Fxsch
Copy link

Fxsch commented Mar 25, 2024

I uploaded it here

@Majklovitch
Copy link

Thanks, it's working perfectly and made the desktop whole lot cleaner. Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GNOME 45 support