-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gnome 45 port #137
Gnome 45 port #137
Conversation
I've just tested this on Fedora 39 Beta, and it seems to work as you described, window shadow stay when using the workspace indicator or overview to switch, can't test touchpad switching as this is on desktop. I think |
tried it for a few hours already, works like a charm. Thanks! |
Works so well i will report any issues |
No issue so far Let's goooo!!!! |
Just tested this on Fedora 39 with an NVIDIA GPU. No issues with the extension - the only wrinkle was that I had to restart my shell session before the extension was fully installed. Thanks! |
This seems to just be how the |
thanks, this works without issues for me! |
Thanks so much. Works without issues for me also so far. Just remember to restart gnome-extensions after the install. |
I've been using it for the last couple of days, I've seen no regressions |
works fine on ubuntu 23.10 |
Works well for me too on Arch gnome 45. |
I tested it on Arch GNOME 45 as well and it seems to work perfectly fine |
Works great for me... ArcoLinux, Gnome 45 |
This works for me. Arch, Gnome 45 👍🏼 |
works for me too on Arch, @yilozt can you rebase and get https://github.com/yilozt/rounded-window-corners/tree/rounded-all-windows-in-overview branch in before pushing this to gnome extensions and close #93 ? |
Works really good for me! tysm!!!! Fedora 39 Beta |
Works great, thank you! |
Ubuntu 23.10 tested, works like a charm here. |
Thanks, now almost all the extensions that I like are on Gnome 45. Maybe by the time Fedora 39 is out, all my extensions would have been ported. |
OpenSUSE Tumbleweed using Gnome 45, been using it for a week now. Works like a charm, 0 issues so far. |
Tested on Manjaro Gnome 45, and woks without issues. Thanks for all. |
Used the gnome 45 version for a few weeks now, no issues. |
Please release it on the extension store |
@yilozt Could you please merge it and release it on the extension store? Please... |
I am very sorry that i am too lazy recently, I will review and release new version in this weekend.😭😭😭😭😭发件人: DavidWoli ***@***.***>发送时间: 2023年11月7日星期二 23:01收件人: yilozt/rounded-window-corners ***@***.***>抄送: Yi ***@***.***>; Mention ***@***.***>主题: Re: [yilozt/rounded-window-corners] Gnome 45 port (PR #137)
@yilozt Could you please merge it and release it on the extension store? Please...
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@yilozt Can you take a look at #137 (comment) please ? |
I will take a looks for the PR to rounded all window in overview.
|
* Delete unuseless align formatter when building
extensionUtils.d.ts have been removed in gnome 45
4423a44
to
d51fa4e
Compare
I can confirm that using https://github.com/yilozt/rounded-window-corners/actions/runs/6839498020 works on Fedora 39 with Gnome 45 |
@yilozt Can you release a new version so we can install it via GNOME extensions instead of manually using GitHub artifacts? Thank you! |
Apparently the Artifact expired and it's no longer for download. Is there a way I can get it? |
I uploaded it here |
Thanks, it's working perfectly and made the desktop whole lot cleaner. Cheers |
Now let's try to move this extension to Gnome 45. This PR do nothing, just update the
import
declarations for Gnome 45.Fixes #130
You can help test this PR via open Github Actions: https://github.com/yilozt/rounded-window-corners/actions?query=branch%3Agnome-45-port, then download the extensions that pack from GitHub Actions:
recording_.webm
Then install extensions via:
Now you can help to test this extensions in Gnome 45~
Some problems to solve:
WorkspaceGroup
class has been private in Gnome 45. We can't access it directly anymore. We need find a way to implement this features.Or you can install Desktop Cube and switch workspace by drag the desktop, you will find that the shadow we add for window has gone.
addBackgroundMenu()
, this extensions can't add on popup menu to open preferences page when gnome-shell startup.console.log()
to logging.https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging
[ ] Usewill finish this feature when i have free time.libadwaita
for preferences window ui?