-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: V2.0 #493
Merged
Merged
feat: V2.0 #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
yihong0618
commented
Sep 17, 2023
•
edited
Loading
edited
- typescript
- vite build
- remove gatsby
- change scripts dir name to run_page for future develop
- update to react 18 and react-map-gl version
- better actions
- use pnpm
* feat: Typescript! Signed-off-by: Frost Ming <[email protected]> * chore: use node 16 as the base Signed-off-by: Frost Ming <[email protected]> * fix: remove use dependencies Signed-off-by: Frost Ming <[email protected]> --------- Signed-off-by: Frost Ming <[email protected]>
feat: change to react and vite Signed-off-by: Frost Ming <[email protected]>
Signed-off-by: shaoanianche <[email protected]>
* This commit do these things, cause react update to 18 there is a serious bug for react-map-gl, so we deside to update it to v7. for v7 there's a lot of break change, we fix them as follows: - bring mapbox css to the file. - change the api that break - add two packages in it to fit the change - change viewport name to viewState to fit the api change * fix: git ignore * style: * line blur to smooth * mapStyle using dark-v10 to solve the language problem * FullscreenButton style fix --------- Co-authored-by: ben_29 <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yihong0618
requested review from
shaonianche,
ben-29,
vlin,
geekplux,
kenwoodjw,
frostming and
Mayandev
September 17, 2023 14:05
ben-29
approved these changes
Sep 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great jobs, I've tested it in local dev env, works like a charm.
One small issue, I think you need to reimport the project on Vercel and start as Vite project, or the preview link won't work.
@ben-29 yes... |
Signed-off-by: friendsa <[email protected]>
vlin
reviewed
Sep 18, 2023
vlin
approved these changes
Sep 19, 2023
yihong0618
had a problem deploying
to
github-pages
September 23, 2023 10:00
— with
GitHub Actions
Failure
yihong0618
temporarily deployed
to
github-pages
September 23, 2023 10:02
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.