Introduce UI changes for ForensicArtifacts indicator type #146
Conversation
| .filter(detail => detail["loc"][2].toLowerCase() === this.typeDefinition.type) | ||
| .map(detail => { | ||
| return { field: detail.loc[1], message: detail.msg }; | ||
| return { field: detail["loc"][3], message: detail.msg }; |
There was a problem hiding this comment.
just for my own understanding. Why are you now using 2 for type checking and returning 3 for field?
There was a problem hiding this comment.
FastAPI returns a weird structure that I had to guess how to parse. the [2] item is which Class the error is comming from (Regexp, ForensicArtifact) and the [3] item is which field in the Class is giving that error.
| { field: "name", type: "text", label: "Name", displayList: true, editable: true }, | ||
| { field: "pattern", type: "code", label: "Pattern", displayList: false, editable: true }, | ||
| { field: "relevant_tags", type: "list", label: "Relevant tags", displayList: true, editable: true }, | ||
| { field: "location", type: "text", label: "Location", displayList: true, editable: true }, | ||
| { field: "location", type: "text", label: "Location", displayList: false, editable: true }, |
There was a problem hiding this comment.
Do you think it's not worth displaying location?
There was a problem hiding this comment.
In the list, it takes a lot of space and adds little value. I guess it probably depends what your dataset looks like. Ideally, we could turn this into a toggle so users can pick what columns to display. 💡
There was a problem hiding this comment.
#147 for good measure
No description provided.