Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unblock upgrading to rules_pkg 0.10 #12

Merged
merged 1 commit into from
Nov 12, 2024
Merged

unblock upgrading to rules_pkg 0.10 #12

merged 1 commit into from
Nov 12, 2024

Conversation

chrisirhc
Copy link
Contributor

@chrisirhc chrisirhc commented Nov 12, 2024 •
edited by yanndegat
Loading

Fixes #10
Fixes #11

TODOs (no ETA, anyone can feel free to take over):

  • This PR doesn't update the rules_pkg version so it'll likely break CI / tests.

@yanndegat
Copy link
Owner

yanndegat commented Nov 12, 2024 •
edited
Loading

hi @chrisirhc

Thanks a lot for spotting this. i've tested it against rules_pkg 0.9 and 0.10 and it works fine.

until i ask for a release in the bcr, you can use a git_override rule. thanks again

@yanndegat yanndegat marked this pull request as ready for review November 12, 2024 08:34
@yanndegat yanndegat merged commit 3772059 into yanndegat:main Nov 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@chrisirhc @yanndegat