Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

threshold percentage value seems to be getting ignored #46

Open
sjethvani opened this issue Jan 23, 2018 · 0 comments
Open

threshold percentage value seems to be getting ignored #46

sjethvani opened this issue Jan 23, 2018 · 0 comments

Comments

@sjethvani
Copy link

sjethvani commented Jan 23, 2018

I am comparing two images and passing parameters like '--threshold-type' percent & '--threshold' somevalue to Pass/Fail comparison on base of threshold .
However it seems threshold value is not getting honored

D:\>node d:\node_modules\blink-diff\bin\blink-diff --verbose --threshold-
type percent --threshold 0.001% --output compare1.png previous_release1.png next_release1.png
Blink-Diff 1.0.13
Copyright (C) 2014 Yahoo! Inc.
Images are similar
386 pixels are different
Wrote differences to compare1.png
Time: 833.052ms
Differences: 386 (0.05%)
PASS

However when I pass threshold as 0% (--threshold 0%) , it works as expected and FAILs comparison when difference is > 0%.

D:\>node d:\node_modules\blink-diff\bin\blink-diff --verbose --threshold-
type percent --threshold 0% --output compare1.png previous_release1.png next_release1.png
Blink-Diff 1.0.13
Copyright (C) 2014 Yahoo! Inc.
Images are visibly different
386 pixels are different
Wrote differences to compare1.png
Time: 846.282ms
Differences: 386 (0.05%)
FAIL
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant