Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

Ignores completely new additions #34

Open
stevenvachon opened this issue Oct 24, 2016 · 4 comments
Open

Ignores completely new additions #34

stevenvachon opened this issue Oct 24, 2016 · 4 comments

Comments

@stevenvachon
Copy link

stevenvachon commented Oct 24, 2016

... that are beyond the boundaries of imageA.

For example, with this code:

new BlinkDiff({
  hideShift: true,  // hide anti-aliasing differences (from composited image)
  imageA: imageA,
  imageB: imageB
})
.run((error, result) => console.log(result.differences);

... these two images result in a logged 0;

imageA:
imageA
imageB:
imageB

@benzaita
Copy link

benzaita commented Dec 5, 2016

This is because blinkdiff always clips the images to the minimum of the two

@stevenvachon
Copy link
Author

I think that this behaviour should be optional. Does it throw errors otherwise?

@benzaita
Copy link

benzaita commented Dec 5, 2016

I totally agree (I do not maintain this repo, though)

@benzaita
Copy link

benzaita commented Dec 5, 2016

Also to the best of my knowledge it does not throw an error. It simply compares the common part (dimension wise) like you saw.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants