Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate source URLs for wrapper links automatically #221

Open
amcclain opened this issue Jul 8, 2019 · 2 comments
Open

Generate source URLs for wrapper links automatically #221

amcclain opened this issue Jul 8, 2019 · 2 comments
Assignees

Comments

@amcclain
Copy link
Member

amcclain commented Jul 8, 2019

Realizing that our github URL routes would be better if we auto-created them based on the versions of hoist-react and toolbox instead of relying on us to update (and then forget to update) the sourceUrls config.

Goal is to put the right branch/tag in the URLs - i.e. for production toolbox I am just updating the config to be:

{
  "hoistReact": "https://github.com/exhi/hoist-react/blob/v24.2.0",
  "toolbox": "https://github.com/exhi/toolbox/blob/v1.15.0"
}

The stems of the URLs aren't gonna change - we just need to update that last bit. I think we can look at the versions of hoist and toolbox and either
a) use develop in the URLs if they are snapshots
b) use the version tag if they are versioned builds

Then we should be able to remove the config entirely and not worry about updating.

@lbwexler
Copy link
Member

Any chance that as part of this, we could create a token to "this example". Would be nice not to have to maintain that self-referential link everywhere.

@amcclain amcclain self-assigned this Jul 17, 2019
@amcclain
Copy link
Member Author

I looked a bit at options to get a reference to the current unbundled file name/path - it's an interesting question. It seemed like there was one option involving some node settings and variables that might be workable - I can play with it a bit more.

I'll also handle this ticket as I had created and have the plan for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants