Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking log entry will print encoded characters #228

Open
febbraiod opened this issue Dec 8, 2021 · 3 comments
Open

Tracking log entry will print encoded characters #228

febbraiod opened this issue Dec 8, 2021 · 3 comments

Comments

@febbraiod
Copy link
Member

Screen Shot 2021-12-08 at 5 29 54 PM

In the client app, the tracking args are pass from the client via a promise chain with a call to .track().

The ampersand is part of the category field and I see it properly in the headers if I look at the network tab (ie NOT encoded).

@ghost ghost assigned cnrudd Dec 15, 2021
@amcclain
Copy link
Member

@cnrudd would you be able to take a look here? Note that the fix might be in hoist-core.

@lbwexler
Copy link
Member

This is in fact in Hoist Core -- see:

return input ? Encode.forHtmlContent(input) : input

Moving to that project

@lbwexler lbwexler transferred this issue from xh/hoist-react Dec 29, 2021
@lbwexler
Copy link
Member

Realize we discussed this, and perhaps even this very url, but putting it here for reference, as its very helpful for me in thinking about this:
https://benhoyt.com/writings/dont-sanitize-do-escape/

Wondering if we can reconsider this, and look toward doing this particular sanitization where we display. React should handle it, and so should our store/ag-Grid assembly.

Realize this has all come up -- thought it might be worth revisiting in the context of this particular bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants