Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genesis fix for x86_64 #7460

Merged
merged 5 commits into from
Sep 10, 2024
Merged

Genesis fix for x86_64 #7460

merged 5 commits into from
Sep 10, 2024

Conversation

abhishek-sa1
Copy link
Contributor

The PR is to fix issue

#7401
#7385

@abhishek-sa1
Copy link
Contributor Author

@ocfmatt @Obihoernchen

@abhishek-sa1
Copy link
Contributor Author

New genesis rpm and deb file has to be created in xCAT tarball.

Copy link

@ocfmatt ocfmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

I've had reports of similar issues with drivers from OCF engineers when using Intel E810 family nics so I am definitely in favour of this change to alleviate that.

What is the purpose of the raw ipmi command on doxcat line 427 and 434?

Regards,
Matt.

@abhishek-sa1
Copy link
Contributor Author

abhishek-sa1 commented Jul 29, 2024

@ocfmatt Sometime even after apply ipmitool chassis bootdev pxe, it doesn't get effective due to timeout of boot(i.e. it should boot within 60 seconds). ipmitool raw 0x00 0x08 0x03 0x08 is valid Bootflag clearing ipmi command
and apply PXE in all the cases. Verified in Dell PowerEdge servers.

@ocfmatt
Copy link

ocfmatt commented Jul 29, 2024

@ocfmatt Sometime even after apply ipmitool chassis bootdev pxe, it doesn't get effective due to timeout of boot(i.e. it should boot within 60 seconds). ipmitool raw 0x00 0x08 0x03 0x08 is valid Bootflag clearing ipmi command and apply PXE in all the cases. Verified in Dell PowerEdge servers.

@Obihoernchen I haven't seen this on any recent OCF deployments. Have you run into this issue before?

@Obihoernchen Obihoernchen added this to the 2.17 milestone Jul 30, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@abhishek-sa1
Copy link
Contributor Author

@ocfmatt Sometime even after apply ipmitool chassis bootdev pxe, it doesn't get effective due to timeout of boot(i.e. it should boot within 60 seconds). ipmitool raw 0x00 0x08 0x03 0x08 is valid Bootflag clearing ipmi command and apply PXE in all the cases. Verified in Dell PowerEdge servers.

@Obihoernchen I haven't seen this on any recent OCF deployments. Have you run into this issue before?

@ocfmatt Can you verify the change in your environment. I can revert this change if required.

@ocfmatt
Copy link

ocfmatt commented Aug 1, 2024

@ocfmatt Sometime even after apply ipmitool chassis bootdev pxe, it doesn't get effective due to timeout of boot(i.e. it should boot within 60 seconds). ipmitool raw 0x00 0x08 0x03 0x08 is valid Bootflag clearing ipmi command and apply PXE in all the cases. Verified in Dell PowerEdge servers.

@Obihoernchen I haven't seen this on any recent OCF deployments. Have you run into this issue before?

@ocfmatt Can you verify the change in your environment. I can revert this change if required.

I will test this and see what impact it has on non-Dell hardware. Worst case scenario I will cherry pick everything but the raw IPMI from your PR.

Thanks,
Matt.

@abhishek-sa1
Copy link
Contributor Author

@ocfmatt @Obihoernchen Is it verified in non-dell hardware?

@rshawocf
Copy link

@abhishek-sa1 I am testing this and will work with @ocfmatt on it. So far I have replicated the original problem #7385 and going to test the fix

@rshawocf
Copy link

rshawocf commented Sep 3, 2024

Update - in our R&D environment the code in PR7460 works fine on Virtual Machines. We still need to test this on non-Dell hardware and will look to do this as soon as possible,

@Obihoernchen Obihoernchen merged commit d8ce286 into xcat2:master Sep 10, 2024
1 of 2 checks passed
@ocfmatt
Copy link

ocfmatt commented Sep 11, 2024

This has already been merged but I have been able to confirm these changes do not have any detrimental impact to a Lenovo SR630 V2 server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants