Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We certainly don't need to create the mask as float64. To keep the missing values masked using np.nan, switching only to float32. We could, in theory, use something like int16 but then we would need to map missing values to -1 or something and treat them later. If we do that before passing to the groupby, then we need a
where
mask resulting in another float32 array (once masked), so there's no point. We could also remove -1 after groupby but then we're doing aggregation on stuff we don't care about. So let's stick with float32 for now.Closes #76