Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Button remains disabled despite selecting a database in the tree widget #821

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Button remains disabled despite selecting a database in the tree widget #821

wants to merge 2 commits into from

Conversation

joko3ono
Copy link
Collaborator

@joko3ono joko3ono commented Nov 21, 2024 •
edited
Loading

This PR addresses an issue where triggering a checkbox change event in ReactJS failed to respond as expected when a database node was selected in jsTree.

Changes Made:

  1. Logic Adjustment:

    • Instead of relying on the checkbox event change to handle the database selection, a new approach has been implemented.
    • When a user selects a database node on jsTree, the database is now set directly as selected without relying on the checkbox event trigger.

  2. Improved Event Handling:

    • This change ensures proper synchronization between jsTree selections and ReactJS state updates, providing a smoother user experience.

Impact:

  • Fixes the event-handling bug related to database selection.
  • Enhances consistency between jsTree interactions and ReactJS state management.

@joko3ono joko3ono marked this pull request as ready for review November 21, 2024 03:17
@joko3ono joko3ono mentioned this pull request Nov 21, 2024
Closed
@joko3ono joko3ono linked an issue Nov 21, 2024 that may be closed by this pull request
BLAST button not working with sequenceserver 3.1.3 and tree widget enabled #784
Open
tadast
tadast approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@tadast tadast left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave this a little test and all looks good.

@joko3ono did you consider the latest tree.js react version? Not saying you should've used it, just curious if you evaluated it and what effort would it take to use it. NVM, saw a comment on #799

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadast tadast tadast approved these changes

@yannickwurm yannickwurm Awaiting requested review from yannickwurm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BLAST button not working with sequenceserver 3.1.3 and tree widget enabled
2 participants
@joko3ono @tadast