-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Electron 33 #1234
Open
karaggeorge
wants to merge
26
commits into
main
Choose a base branch
from
george/upgrade-electron
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Upgrade to Electron 33 #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albinekb
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job! 👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades to Electron 33:
remote
to useipc
insteadKnown broken things that were not migrated:
Editor video is not centeredEditor window traffic lights are broken-webkit-app-region: drag;
limitationsI tried to upgrade as few packages as possible. I have another branch that upgrade all our utils, but we need to upgrade the entire project to use ESM (
type: "module"
). I did do that, but then the renderer Next.js app is not working. I tried upgrading Next.js and getting that to work, butelectron-next
was not working with it 🙈Overall, we still have
.js
code, class components, in-linestyled jsx
and a lot of other really outdated codeI think we need to move away from
electron-next
and Next.js, and just have a regular webpack build (or vite) for the renderersAlso, a lot of code needs to be re-written to improve performance, especially the cropper