Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

axis unit setting via ax.units = val setter does not update attrs for the parent object #1081

Open
ksunden opened this issue Jun 23, 2022 · 0 comments

Comments

@ksunden
Copy link
Member

ksunden commented Jun 23, 2022

This results in the units not being updated on disk despite working in memory for the new units

should either be reworked to call the update parent attrs function that is called in convert or to just call convert (and thus have convert set self._units to avoid infinite recursion)

Which option depends on if we wish to allow you to set units via units setter to units that would otherwise raise an exception in convert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant