Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General fixes #105

Open
darklight9811 opened this issue Apr 26, 2022 · 2 comments
Open

General fixes #105

darklight9811 opened this issue Apr 26, 2022 · 2 comments

Comments

@darklight9811
Copy link

darklight9811 commented Apr 26, 2022

Summary

This package is important to the community, we shouldn't let it die. There are still plenty of things to do:

  • Github templates
  • Fix export
  • Change compiler (recommend tsup), to allow both commonjs, and modules to be used
  • Add logout method (suggested on Please add Logout method #100)
  • Listen for popup closing (or timeout)
  • Add jsdoc description to methods
  • add mock ability so the package can be better tested (and also override some behaviors if the user needs it)
  • add github workflow for handling package validation, testing and publish
@niksad8
Copy link
Collaborator

niksad8 commented Feb 22, 2023

thanks we will be implementing some of these functions soon

@niksad8
Copy link
Collaborator

niksad8 commented Mar 30, 2023

from this list we have implemented the following :

  • add logout using the wax.logout() function
  • listen to popup closing done now you will get an exception when the popup is closed and the promise is closed too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants