Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPO tool: recommended changes and feature requests #158

Open
andzajan opened this issue Oct 2, 2019 · 2 comments
Open

IPO tool: recommended changes and feature requests #158

andzajan opened this issue Oct 2, 2019 · 2 comments

Comments

@andzajan
Copy link

andzajan commented Oct 2, 2019

  • IPO for xcmsSet

    • centWave peak picking algorithm needs option to optimise following parameters together:
      peakpickingParameters$min_peakwidth (Range for Min peak width range in seconds)
      peakpickingParameters$max_peakwidth (Range for Max peak width range in seconds)
      peakpickingParameters$ppm (Range for tolerated ppm m/z deviation in consecutive scans in ppm)
      peakpickingParameters$mzdiff (Range for Minimum difference in m/z for peaks with overlapping Retention Times)
  • IPO for group and retcor

    • For grouping method denstiy allow to optimise range of bw and mzwid simultaneously
      retcorGroupParameters$bw (*Range for Bandwidth)
      retcorGroupParameters$mzwid (*Range for width of overlapping m/z slices)
@lecorguille
Copy link
Member

Should be available with this commit: 5a5e663

@andzajan
Copy link
Author

andzajan commented Oct 3, 2019

Thank you @lecorguille, I think there is a problem with parameters input interface now:

  • would be possible for grouping parameter to make that if input is a single value and not a range, to keep that parameter fixed and optimise only other one;
  • for retention time correction method obiwarp parameters are listed as non-optimisable, but m/z step input still has to be range.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants