You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 11, 2021. It is now read-only.
Hi,
I installed kube-slack via the helm chart and tried to use the kube-slack/ignore-pod annotation. Sadly the pods were not ignored, because Javascript returns false if you test for an empty string if(annotations['kube-slack/ignore-pod'])
Would it be possible to either change this to if (typeof annotations['kube-slack/ignore-pod'] !== 'undefined')
or update the documentation to specify that you have to add a value.
Maybe I am the only one who got this wrong.
Thanks
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hi,
I installed kube-slack via the helm chart and tried to use the
kube-slack/ignore-pod annotation
. Sadly the pods were not ignored, because Javascript returnsfalse
if you test for an empty stringif(annotations['kube-slack/ignore-pod'])
Would it be possible to either change this to
if (typeof annotations['kube-slack/ignore-pod'] !== 'undefined')
or update the documentation to specify that you have to add a value.
Maybe I am the only one who got this wrong.
Thanks
The text was updated successfully, but these errors were encountered: