Skip to content
This repository has been archived by the owner on Jan 11, 2021. It is now read-only.

kube-slack/ignore-pod annotation does not work if you set an empty string as value. #63

Open
SimonHessel opened this issue Mar 16, 2020 · 0 comments

Comments

@SimonHessel
Copy link

Hi,
I installed kube-slack via the helm chart and tried to use the kube-slack/ignore-pod annotation. Sadly the pods were not ignored, because Javascript returns false if you test for an empty string
if(annotations['kube-slack/ignore-pod'])

Would it be possible to either change this to
if (typeof annotations['kube-slack/ignore-pod'] !== 'undefined')

or update the documentation to specify that you have to add a value.
Maybe I am the only one who got this wrong.
Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant