You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the moment we're forced to writing our own wrappers around SymSpell that would allow mocking the class in our unit tests.
A predefined interface (or at least virtual attributes on most of the compute-intensive methods) would remove this requirement.
P.S. I'm happy with doing a pull request in case it is an acceptable change
The text was updated successfully, but these errors were encountered:
I see your point. But both Javascript and Python don't support the interface concept, while they are the most actively used ports of SymSpell. And even in the other languages probably not all developers are familiar with that concept. This would lead to fewer or more deviating ports.
Therefore I would like to keep it simple and stick to basic language features which easily can be understood and ported to other languages.
At the moment we're forced to writing our own wrappers around SymSpell that would allow mocking the class in our unit tests.
A predefined interface (or at least virtual attributes on most of the compute-intensive methods) would remove this requirement.
P.S. I'm happy with doing a pull request in case it is an acceptable change
The text was updated successfully, but these errors were encountered: