Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality of Life #52

Merged
merged 20 commits into from
Nov 26, 2023
Merged

Quality of Life #52

merged 20 commits into from
Nov 26, 2023

Conversation

woctezuma
Copy link
Owner

@woctezuma woctezuma commented Nov 26, 2023

  • Skip download of market orders for recently updated listings
  • Add a toggle to allow to only skip downloading of orders if data is BOTH recent AND not dummy
  • Fix S113 (ruff): Probable use of requests call without timeout
  • Catch ReadTimeout errors
  • Propagate some arguments up to main()
  • Update some data snapshots

…n timestamps for market orders

By default, the argument is set to True, i.e. the cooldown is taken into account.
…and volumes)

In this case, the timestamp is set to 0.
- add a "[WARNING]" prefix
- use "timeout" instead of "timed out"
…nd not dummy

This allows to avoid setting the timestamp to 0 to convey unrelated info about dummy market data. Semantics are clearer after this change.
@woctezuma woctezuma added the enhancement New feature or request label Nov 26, 2023
@woctezuma woctezuma self-assigned this Nov 26, 2023
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (18cee42) 39.41% compared to head (e21d38b) 39.37%.

Files Patch % Lines
src/market_order.py 30.00% 21 Missing ⚠️
src/market_search.py 40.00% 3 Missing ⚠️
src/download_steam_card_exchange.py 0.00% 2 Missing ⚠️
src/market_foil_utils.py 0.00% 2 Missing ⚠️
src/cookie_utils.py 50.00% 1 Missing ⚠️
src/creation_time_utils.py 50.00% 1 Missing ⚠️
src/free_games_with_trading_cards.py 0.00% 1 Missing ⚠️
src/inventory_utils.py 0.00% 1 Missing ⚠️
src/market_listing.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
- Coverage   39.41%   39.37%   -0.04%     
==========================================
  Files          27       27              
  Lines        2514     2547      +33     
==========================================
+ Hits          991     1003      +12     
- Misses       1523     1544      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@woctezuma woctezuma merged commit f6cea78 into master Nov 26, 2023
3 of 5 checks passed
@woctezuma woctezuma deleted the update-time branch November 26, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant