Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsdoc-toolbar needs position:relative #61

Open
lbod opened this issue Jun 27, 2013 · 1 comment
Open

jsdoc-toolbar needs position:relative #61

lbod opened this issue Jun 27, 2013 · 1 comment

Comments

@lbod
Copy link

lbod commented Jun 27, 2013

Strange I only noticed this the other night (as it looks like it's been there for some time?) but you'll see the if you scroll down a module content pane e.g. http://dojotoolkit.org/api/1.9/dijit/MenuBarItem the jsdoc-toolbar contents don't scroll and the position is static.

edit: unless you want it to remain fixed which is a different issue

@wkeese
Copy link
Owner

wkeese commented Jun 28, 2013

I've noticed that before too. The current behavior is definitely wrong, because when you scroll, the main text and the toolbar text appear on top of each other, and the user can't read anything.

As to whether the toolbar should be position:static (along with a position:static opaque background) or should scroll with the module content, I don't have an opinion. A few years ago it was popular to partition the screen with lots of little scrollable regions and lots of static non-scrolling areas, but with the advent of mobile's small screens that seems to have fallen out of fashion. OTOH the API viewer follows the old design in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants