-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: unify schemes and test plans - WPB-11406 #2217
Merged
caldrian
merged 12 commits into
release/cycle-3.114
from
chore/unify-schemes-and-testplans-WPB-11406
Nov 28, 2024
Merged
chore: unify schemes and test plans - WPB-11406 #2217
caldrian
merged 12 commits into
release/cycle-3.114
from
chore/unify-schemes-and-testplans-WPB-11406
Nov 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: technical-roadmap/throughput
More specific category, to highlight task aiming at improving the development velocity and effici...
label
Nov 27, 2024
Test Results 21 files 1 055 suites 14m 23s ⏱️ Results for commit c62186a. ♻️ This comment has been updated with latest results. |
caldrian
commented
Nov 27, 2024
…o chore/unify-schemes-and-testplans-WPB-11406
caldrian
commented
Nov 27, 2024
wire-ios-link-preview/WireLinkPreviewTests/TestPlans/E2ETests.xctestplan
Show resolved
Hide resolved
netbe
approved these changes
Nov 27, 2024
…o chore/unify-schemes-and-testplans-WPB-11406
samwyndham
reviewed
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @caldrian. Two questions:
- Could you give a bit more information in the description about what will specifically be different once this PR merged. Just because there is a lot of changes.
- Just to check should this PR definitely be targeting release brach and not develop.
samwyndham
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
echoes: technical-roadmap/throughput
More specific category, to highlight task aiming at improving the development velocity and effici...
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
As a preparation for PR #1707 this PR
Testing
Automatic tests should pass.
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: