refactor: process conversation typing event - WPB-10178 #2194
Conversation
echoes-hq
bot
added
the
echoes: technical-roadmap/technical-debt
| import WireDataModel | ||
|
|
||
| /// Keeping track of typing users timeouts | ||
| final class ConversationTypingUsersTimeout: NSObject, ZMTimerClient { |
There was a problem hiding this comment.
Please check this page here for specifics regarding the business logic related to typing users timeouts.
| uiContext.typingUsers?.update( | ||
| typingUsers: Set(users), | ||
| in: conversation | ||
| ) |
There was a problem hiding this comment.
The underlying implementation (typingUsers?.update..) was not accessible from WireDomain (it was part of WireSyncEngine) so in this PR, TypingUsers object and the related NSManagedObjectContext extension were moved from WireSyncEngine to WireDataModel.
At the app level, the ConversationInputBarViewController relies on this code. Now that it is accessible in WireDataModel, we can reuse the same methods from WireDomain so when we plug our new quick sync mechanism, UI won't break (although it should probably be refactored as well eventually)
There was a problem hiding this comment.
This definitely needs refactoring... we shouldn't store anything on the managed object context. Do you think it's something we can do in this PR or it's too big?
| public struct TypingUsersInfo { | ||
| let users: Set<NSManagedObjectID> | ||
| let conversationID: NSManagedObjectID | ||
| } | ||
|
|
There was a problem hiding this comment.
I suggest to move this to a separate file and add doc comments.
| conversationLocalStore.obtainPermanentIDs( | ||
| user: user, | ||
| conversation: conversation | ||
| ) |
There was a problem hiding this comment.
Is this something that can be internal to the stores?
| uiContext.typingUsers?.update( | ||
| typingUsers: Set(users), | ||
| in: conversation | ||
| ) |
There was a problem hiding this comment.
This definitely needs refactoring... we shouldn't store anything on the managed object context. Do you think it's something we can do in this PR or it's too big?
Key points
This PR is part of the quick sync refactoring plan and is related to processing the multiple events we receive from the backend or the push channel.
Specifically, this PR is about porting the existing implementation of the
ConversationTypingevent.The legacy code for processing that event was fully part of WireSyncEngine, some objects (
TypingUsers) were moved from WireSyncEngine to WireDataModel for backward compatibility so when we plug our new quick sync mechanism UI don't break. (see comment for specifics)Testing
ConversationTypingUsersTimeoutread/write methods (add, remove, contains..)ConversationTypingEventProcessorrepo and local store methods invocations.ConversationRepositorya notification with the typing users data is correctly sent.Checklist
[WPB-XXX].