Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the components design #3

Open
wj-Mcat opened this issue Nov 14, 2021 · 0 comments
Open

Refactor the components design #3

wj-Mcat opened this issue Nov 14, 2021 · 0 comments

Comments

@wj-Mcat
Copy link
Collaborator

wj-Mcat commented Nov 14, 2021

Description

All of itchat method is encapsulated into split module, eg: contact, login, message, hotreload, which is attached to the Core object. Because all of submodule in components module is in the same class: Core, so we can pack all of methods into one Object: AsyncItchat which is the async-based itchat.

Design

In this case, all of methods in components is in same class and there are so many common codes can be refactored. I believe if this change has been done, it will make code smaller and more elegant.

@wj-Mcat wj-Mcat changed the title Refactor the compoents design Refactor the components design Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant