Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: url service #108

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

refactor: url service #108

wants to merge 4 commits into from
+34,437 −5,449

Conversation

FantasyRL
Copy link
Member

@FantasyRL FantasyRL commented Nov 24, 2024 •
edited
Loading

todo:
不使用静态文件，而是使用upyun
将隐私政策移到common

一些问题:
testSetting(/api/test)这个接口逻辑和get_setting基本一致
setcloud不能直接调试，因为格式是不正确的不能解析，apifox没有自动加换行符，我觉得不如传文件更好点

@FantasyRL FantasyRL linked an issue Nov 24, 2024 that may be closed by this pull request
refactor the url module #102
Open
@FantasyRL FantasyRL closed this Nov 27, 2024
@FantasyRL FantasyRL deleted the not_main branch November 27, 2024 01:34
@FantasyRL FantasyRL reopened this Nov 27, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 1.08291% with 2923 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
api/model/model/model.go 0.00% 509 Missing ⚠️
kitex_gen/model/model.go 0.00% 504 Missing ⚠️
kitex_gen/model/k-model.go 0.00% 396 Missing ⚠️
kitex_gen/url/urlservice/urlservice.go 8.14% 326 Missing and 1 partial ⚠️
api/handler/api/url_service.go 0.00% 178 Missing ⚠️
internal/url/handler.go 0.00% 137 Missing ⚠️
api/rpc/url.go 0.00% 126 Missing ⚠️
internal/url/service/get_setting.go 0.00% 110 Missing ⚠️
api/handler/custom/url_service.go 0.00% 106 Missing ⚠️
api/router/api/middleware.go 0.00% 75 Missing ⚠️
... and 28 more
Flag Coverage Δ
unittest 0.90% <1.08%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/model/api/api.go 0.00% <ø> (ø)
internal/launch_screen/service/create_image.go 93.18% <100.00%> (+0.49%) ⬆️
kitex_gen/url/k-url.go 0.00% <ø> (ø)
kitex_gen/url/url.go 0.00% <ø> (ø)
api/rpc/init.go 0.00% <0.00%> (ø)
config/config.go 0.00% <0.00%> (ø)
api/handler/api/user_service.go 0.00% <0.00%> (ø)
pkg/base/client/rpc.go 0.00% <0.00%> (ø)
pkg/utils/check_pwd.go 0.00% <0.00%> (ø)
internal/url/service/login.go 0.00% <0.00%> (ø)
... and 32 more

... and 9 files with indirect coverage changes

@FantasyRL FantasyRL marked this pull request as ready for review November 28, 2024 09:44
@FantasyRL FantasyRL requested review from ozline and a team as code owners November 28, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchwarzSail SchwarzSail Awaiting requested review from SchwarzSail

@penqee penqee Awaiting requested review from penqee

@mutezebra mutezebra Awaiting requested review from mutezebra mutezebra is a code owner

@jiuxia211 jiuxia211 Awaiting requested review from jiuxia211 jiuxia211 is a code owner

@ozline ozline Awaiting requested review from ozline ozline is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor the url module
1 participant
@FantasyRL