-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unnessasarry comment inside of dist/ARnft.js #283
Comments
Hi @tkapu ARnft is based on webarkit/jsartoolkitNFT the base64 code that you were reading is the WASM bitecode bundled with webpack, if you remove that code you will remove the core of it. Probably it is possible to reduce jsartoolkitNFT WASM code reducing emscripten code, but this is not a prority for me. |
Hi @kalwalt, |
I used the TerserPlugin as you can see Lines 48 to 56 in 5a66982
I don't see this second line. Maybe have you build the distribution library with the dev option? |
I'm using "yarn build-ts" from the readme file. I was missing the optimization part, but it didn't change my result. You can see the second line in the file hear on github |
If you look into the ARnft.js file, then you will notice that about half the file is just commented out Base64 code. I think, that should be removed to reduce the file size.
~1800kb to about ~750kb
The text was updated successfully, but these errors were encountered: